-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to SQLAlchemy 2.x #521
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @JasonWeill, @srdas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little concerned that we have two alert boxes right next to each other, but if we eventually phase out both of them, this won't be a problem in the long run.
* update sqlalchemy to 2.x * Add SQLAlchemy 2.x requirement warning to README and readthedocs * change JupyterLab 3 "will reach" to "reached" * Remove "anywhere on earth" as it's not a relevant information anymore
Jupyter Scheduler uses subset of SQLAlchemy functionality supported in both SQLAlchemy 1.x and 2.x.
Updating to SQLAlchemy 2.x would allow people who want to use Jupyter Scheduler and other packages that depend on SQLAlchemy 2.x in the same environment (for example, pandas) to do so.
For reference: SQLAlchemy 2.0 - Major Migration Guide .
Fixes #478.
Will also fix a SQLAlchemy 1.x depreciation warning failing CI in #520: https://github.com/jupyter-server/jupyter-scheduler/actions/runs/9179340732/job/25241262049?pr=520#step:6:463