Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry patch #457

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Telemetry patch #457

merged 5 commits into from
Oct 31, 2023

Conversation

3coins
Copy link
Collaborator

@3coins 3coins commented Oct 31, 2023

Moved the event logger handler up in the stack to capture launcher, context menu and notebook header events.

@3coins 3coins added the enhancement New feature or request label Oct 31, 2023
@3coins 3coins marked this pull request as ready for review October 31, 2023 16:51
src/index.tsx Outdated Show resolved Hide resolved
src/index.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The doc comment was forgotten, but now that the implementation is obviously a no-op, I think the intent is sufficiently clear.

@3coins 3coins merged commit f453aac into jupyter-server:main Oct 31, 2023
6 checks passed
3coins added a commit to 3coins/jupyter-scheduler that referenced this pull request Oct 31, 2023
* Moved event logger handler up the stack.

* Fixed lint errors

* Combined handler, and plugin.

* Fixed lint errors

* separate launcher command and rename show-notebook-jobs (#3)

---------

Co-authored-by: david qiu <[email protected]>
3coins added a commit that referenced this pull request Oct 31, 2023
* Moved event logger handler up the stack.

* Fixed lint errors

* Combined handler, and plugin.

* Fixed lint errors

* separate launcher command and rename show-notebook-jobs (#3)

---------

Co-authored-by: david qiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants