Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Notification support #446

Draft
wants to merge 75 commits into
base: main
Choose a base branch
from
Draft

Add Notification support #446

wants to merge 75 commits into from
+499 −43

Commits on Nov 1, 2023

  1. Add NotificationEvent Enum

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    73a938b View commit details
    Browse the repository at this point in the history

  2. Mention enum in the docstring

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    b37aa2b View commit details
    Browse the repository at this point in the history

  3. add Notification class

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    2ff82d4 View commit details
    Browse the repository at this point in the history

  4. Add notification-related fields to RuntimeEnv

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    ce7d5e1 View commit details
    Browse the repository at this point in the history

  5. add notification field to JobDef models

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    3bbfd76 View commit details
    Browse the repository at this point in the history

  6. add notification to Job models

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    cf70931 View commit details
    Browse the repository at this point in the history

  7. add notification to Job and JobDef orm classes

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    04a9bc8 View commit details
    Browse the repository at this point in the history

  8. add __str__ to NotificationEvent

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    199be36 View commit details
    Browse the repository at this point in the history

  9. add notifications to front-end models

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    bedc97f View commit details
    Browse the repository at this point in the history

  10. add BaseModel to Notification class

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    276188e View commit details
    Browse the repository at this point in the history

  11. make NotificationEvent a StrEnum

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    6eea203 View commit details
    Browse the repository at this point in the history

  12. use list comprehension for notification_events

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    3ed5f7f View commit details
    Browse the repository at this point in the history

  13. create notitifactions-picker component

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    c473c6c View commit details
    Browse the repository at this point in the history

  14. add notifications_picker to create-job

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    98731d9 View commit details
    Browse the repository at this point in the history

  15. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @andrii-i
    pre-commit-ci[bot] authored and andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    b341f49 View commit details
    Browse the repository at this point in the history

  16. add NotificationsPicker component

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    011a315 View commit details
    Browse the repository at this point in the history

  17. ad NotificationsPicker to create job form

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    d58fb03 View commit details
    Browse the repository at this point in the history

  18. add Notification type, use it in ICreateJobModel

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    bfdde0d View commit details
    Browse the repository at this point in the history

  19. disable notifications by default

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    7e4237c View commit details
    Browse the repository at this point in the history

  20. code formatriing

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    873882f View commit details
    Browse the repository at this point in the history

  21. Use (str, Enum) not StrEnum to work w Python <3.11

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    415f9e3 View commit details
    Browse the repository at this point in the history

  22. addd notification events chips

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    1e157ec View commit details
    Browse the repository at this point in the history

  23. use NotificationPicker

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    be04bf6 View commit details
    Browse the repository at this point in the history

  24. make sendTo optional and add enableNotification to models

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    dca3492 View commit details
    Browse the repository at this point in the history

  25. account for sendTo being optional

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    d331ad8 View commit details
    Browse the repository at this point in the history

  26. add enable notifications toggle

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    d86a6f4 View commit details
    Browse the repository at this point in the history

  27. make sendTo a string[] in all models

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    702dec1 View commit details
    Browse the repository at this point in the history

  28. save sendTo input to model on blur or on enter

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    e002bf6 View commit details
    Browse the repository at this point in the history

  29. add option to Include Output

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    9fc56b6 View commit details
    Browse the repository at this point in the history

  30. use Notification, not Notifications in UI elements

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    766a2e6 View commit details
    Browse the repository at this point in the history

  31. add notification to detail models

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    a191dda View commit details
    Browse the repository at this point in the history

  32. check if enableNotification and set it if not

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    a933dc4 View commit details
    Browse the repository at this point in the history

  33. display notification info in JobDetail

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    bbb5bb6 View commit details
    Browse the repository at this point in the history

  34. clean-up code

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    32eb7f6 View commit details
    Browse the repository at this point in the history

  35. Update Send To, Event indexes to start from 1

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    5a1fa30 View commit details
    Browse the repository at this point in the history

  36. set notifications_enabled to False by default

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    eaa6bc9 View commit details
    Browse the repository at this point in the history

  37. add attrib-s description to Notification, NotificationEvent

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    e9ddade View commit details
    Browse the repository at this point in the history

  38. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @andrii-i
    pre-commit-ci[bot] authored and andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    b0a0f5a View commit details
    Browse the repository at this point in the history

  39. adjust docstring

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    b77d3b1 View commit details
    Browse the repository at this point in the history

  40. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @andrii-i
    pre-commit-ci[bot] authored and andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    2eb0507 View commit details
    Browse the repository at this point in the history

  41. default notification_events to []

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    52c6aa1 View commit details
    Browse the repository at this point in the history

  42. rename "Notification" into "NotificationSettings"

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    8a417bc View commit details
    Browse the repository at this point in the history

  43. Rename INotification --> INotificationsSettings

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    6ee5055 View commit details
    Browse the repository at this point in the history

  44. run prettier

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    848b71e View commit details
    Browse the repository at this point in the history

  45. update local var names to notificationsSettings

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    57f6a75 View commit details
    Browse the repository at this point in the history

  46. convert props to types from interfaces

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    b07e516 View commit details
    Browse the repository at this point in the history

  47. Use Sentence case, not Title Case for field labels

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    711ca24 View commit details
    Browse the repository at this point in the history

  48. conver arrow functions into plain old functions, move props type decl… 

    …arations into separate types
    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    878bca5 View commit details
    Browse the repository at this point in the history

  49. extract SelectedEventsChips props type into a separate type declaration

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    f200838 View commit details
    Browse the repository at this point in the history

  50. NotificationsSettings --> NotificationsConfig

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    319fa80 View commit details
    Browse the repository at this point in the history

  51. rename NotificationsSettings --> NotificationsConfig

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    be78d8b View commit details
    Browse the repository at this point in the history

  52. notifications_settings --> notifications_config

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    142f444 View commit details
    Browse the repository at this point in the history

  53. rename INotificationsConfigDetailProps

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    c8acf42 View commit details
    Browse the repository at this point in the history

  54. make NotificationsConfig a separate table

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    eb0a72a View commit details
    Browse the repository at this point in the history

  55. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @andrii-i
    pre-commit-ci[bot] authored and andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    c68d7cf View commit details
    Browse the repository at this point in the history

  56. change validator signature

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    63ce389 View commit details
    Browse the repository at this point in the history

  57. add pydantic validators

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    1401b86 View commit details
    Browse the repository at this point in the history

  58. correct validator function naming

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    041ba11 View commit details
    Browse the repository at this point in the history

  59. eager load NotificationsConfig relationship by default

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    e63c507 View commit details
    Browse the repository at this point in the history

  60. Utilize more targeted model update function for NotificationsConfig

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    95204d7 View commit details
    Browse the repository at this point in the history

  61. convert NotificationsConfig to dict

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    8757418 View commit details
    Browse the repository at this point in the history

  62. adjust RuntimeEnvironment

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    3503123 View commit details
    Browse the repository at this point in the history

  63. fix orm to pydantic model conversion

    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    9b3ca4f View commit details
    Browse the repository at this point in the history

  64. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @andrii-i
    pre-commit-ci[bot] authored and andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    d905ff5 View commit details
    Browse the repository at this point in the history

  65. fix notifications config pydantic to orm data conversion for create_j… 

    …ob_def
    @andrii-i
    andrii-i committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    1696c51 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. use props.model.notificationsConfig as a basis for NotificationsConfi… 

    …g state
    @andrii-i
    andrii-i committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    740bad8 View commit details
    Browse the repository at this point in the history

  2. remove useCallback to simplify as no perf gains

    @andrii-i
    andrii-i committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    711e3d5 View commit details
    Browse the repository at this point in the history

  3. adjust SelectedEventsChips's onChange

    @andrii-i
    andrii-i committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    3ef4269 View commit details
    Browse the repository at this point in the history

  4. fix chip delete function

    @andrii-i
    andrii-i committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    2e1b2f8 View commit details
    Browse the repository at this point in the history

  5. remove test defaults

    @andrii-i
    andrii-i committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    c434fca View commit details
    Browse the repository at this point in the history

  6. Display "Send to" and "Notification events" as Chips

    @andrii-i
    andrii-i committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    02dccfe View commit details
    Browse the repository at this point in the history

  7. remvoe NotificationsConfigItem

    @andrii-i
    andrii-i committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    29331cf View commit details
    Browse the repository at this point in the history

  8. use LabeledValue for all Notifications Settings items

    @andrii-i
    andrii-i committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    7002908 View commit details
    Browse the repository at this point in the history

  9. represent events as comma-separated list

    @andrii-i
    andrii-i committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    10b3239 View commit details
    Browse the repository at this point in the history

  10. display send to as a comma-separated list of strings in details

    @andrii-i
    andrii-i committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    24f9fdb View commit details
    Browse the repository at this point in the history