Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused s3fs dependency #437

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Remove unused s3fs dependency #437

merged 1 commit into from
Oct 12, 2023

Conversation

andrii-i
Copy link
Collaborator

@andrii-i andrii-i commented Oct 3, 2023 •
edited
Loading

Remove s3fs from the list of dependencies as s3fs is not used anywhere in the Jupyter Scheduler codebase.

@andrii-i andrii-i added dependencies Pull requests that update a dependency file maintenance Maintenance/CI tasks labels Oct 3, 2023
@andrii-i andrii-i mentioned this pull request Oct 3, 2023
Closed
@andrii-i andrii-i marked this pull request as draft October 9, 2023 18:16
@dlqqq
Copy link
Collaborator

dlqqq commented Oct 12, 2023

Rebased onto #438 to fix CI.

@dlqqq dlqqq marked this pull request as ready for review October 12, 2023 00:22
@dlqqq dlqqq changed the title Remove s3fs from the list of dependencies Remove unused s3fs dependency Oct 12, 2023
@dlqqq dlqqq mentioned this pull request Oct 12, 2023
Merged
@dlqqq dlqqq merged commit eab721a into jupyter-server:main Oct 12, 2023
7 checks passed
@andrii-i andrii-i deleted the remove-s3fs-dependency branch January 23, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlqqq dlqqq dlqqq approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file maintenance Maintenance/CI tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrii-i @dlqqq