Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] Fix CI, run lint, reduce end-to-end tests flakiness #425

Merged
merged 11 commits into from
Aug 15, 2023
Merged

[1.x] Fix CI, run lint, reduce end-to-end tests flakiness #425

merged 11 commits into from
Aug 15, 2023

Commits on Aug 15, 2023

  1. modify the commit for 1.x

    @andrii-i
    andrii-i committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    ed25a09 View commit details
    Browse the repository at this point in the history

  2. Fix CI, run lint, reduce end-to-end tests flakiness (jupyter-server#417) 

    * add macos tests

* add locally-generated snapshots

* check if filebrowser is already open before opening it

* add actual snapshoy from CI

* Update Playwright Snapshots

* use notebook toolbar, mask bttns on the right

* correct selector

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* run lint

* Update Playwright Snapshots

* timestampLocator -> timestamp

* wait until fonts are ready before taking a snapshot

* add maxDiffPixels

* Revert "wait until fonts are ready before taking a snapshot"

This reverts commit 9554559.

* pin jupyterlab version for e2e tests and snapshots

* remove macos tests

* rename relevant job to end-to-end test

* remove darwin/macos snapshots

* specify jupyterlab version correctly

* run lint

* add jlpm install to Lint the extension step

* remove ubuntu postfix from test report

* Make e2e tests a separate file

* add build steps

* pin version of jupyterlab in e2e test file

* introduce modifyListResponse, remove maxDiffPixels

* modifyListResponse -> setJobList

* set expected URL

* always set create_time to 1

* update list view snapshot

* run check option for lint

* run lint locally

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
    @andrii-i @github-actions @pre-commit-ci
    3 people committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    9bc45f5 View commit details
    Browse the repository at this point in the history

  3. fix install chromium command

    @andrii-i
    andrii-i committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    c3a9702 View commit details
    Browse the repository at this point in the history

  4. remove playwrght from dev dependencies

    @andrii-i
    andrii-i committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    5a37c4d View commit details
    Browse the repository at this point in the history

  5. fix comma

    @andrii-i
    andrii-i committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    dbc2ced View commit details
    Browse the repository at this point in the history

  6. Roll back 402 changes

    @andrii-i
    andrii-i committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    546f52b View commit details
    Browse the repository at this point in the history

  7. roll back changes to build.yml

    @andrii-i
    andrii-i committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    9402d13 View commit details
    Browse the repository at this point in the history

  8. run lint

    @andrii-i
    andrii-i committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    bab1591 View commit details
    Browse the repository at this point in the history

  9. update snapshots

    @andrii-i
    andrii-i committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    84cea86 View commit details
    Browse the repository at this point in the history

  10. remove integration step

    @andrii-i
    andrii-i committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    d6a4a82 View commit details
    Browse the repository at this point in the history

  11. reinstate d423ede

    @andrii-i
    andrii-i committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    d32f76b View commit details
    Browse the repository at this point in the history