Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "void" and "Void" class lookups in ReflectionUtils #4049

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bjmi
Copy link
Contributor

@bjmi bjmi commented Oct 6, 2024

Fix #4048

@marcphilipp
Copy link
Member

Could you please add an "integration test" demonstrating the scenario from #4048 is now supported?

sbrannen

This comment was marked as outdated.

@sbrannen sbrannen changed the title Support "void" in ReflectionUtils Support "void" and "Void" class lookups in ReflectionUtils Oct 6, 2024
Signed-off-by: Björn Michael <[email protected]>
@bjmi
Copy link
Contributor Author

bjmi commented Oct 6, 2024

Could you please add an "integration test" demonstrating the scenario from #4048 is now supported?

This is now implicitly tested by DefaultArgumentConverterTests.convertsStringToClass().
Should the newly introduced DefaultArgumentConverterTests.IntegrationTests still be retained?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support conversion from "void" and "Void" to Class
3 participants