Use the agent ID instead of unit ID in cluster config dict #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bind address. This may not correspond to the unit's ID.
addresses in the application data bag. This is what is ultimately written to file and used by the agent, which does knows its own ID, but not necessarily the unit's.
SimonRichardson
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dbaccessorworker in the Juju agent needs to recognise its own bind address in the configuration set for the cluster by the controller unit.At this point in Juju's workflow, it does not have the knowledge to reconcile what its local controller unit ID is.
To address this, the application data-bag cluster configuration, and therefore the contents written to disk are keyed on the agent ID rather than the unit ID.