Update controller configuration path #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
controller.conf. This is because on K8s, the agent's configuration is in in the controller-n path instead of machine-n on metal/VMs. We must use a different file name, or we overwrite the agent configuration.
SimonRichardson
approved these changes
Mar 15, 2024
|
We need to release a beta3 of Juju 4 in order to make the CI jobs pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On K8s, the controller's agent configuration is in /var/lib/juju/agents/controller-n/agent.conf instead of a path with machine-n as on machines.
This means that we can't use agent.conf for controller configuration written by the charm, because it overwrites the agent configuration.
Here we change the name to controller.conf to avoid this situation.