parse controller API port from apiaddresses in agent.conf #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpidcock
reviewed
Nov 7, 2023
wallyworld
approved these changes
Nov 8, 2023
- move flake8 to end of run_tests file, so unit tests always run
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes (on k8s), the
apiportkey is not defined inside the unit'sagent.conf. In this case, we need to parse the value given in theapiaddresseskey, which has the formChange the
api_portmethod so that we're parsing theapiaddressesagent.conf key, instead of relying onapiport. If the key can't be found, then the method raises anAgentConfException, which is caught in the event handler and the status is set to 'error'.Add unit tests to cover all this.
As a drive-by, move flake8 to the end of the
run_testsscript, so that unit tests are always run, even if the linting doesn't pass.