-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JUJU-1688] Prometheus integration for Juju #20
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add metrics-endpoint relation - configure MetricsEndpointProvider TODO: add user on relation-joined, remove on relation-departed
- log introspect command
- set scrape config to [] on relation_departed
Store user credentials for Prometheus in stored state, so we can generate the correct scrape config on hook invocations
5 tasks
- don't log full introspection command - don't want to log passwords
Just stumbled across this again, glad to see it :) Probably worth making sure we're using the latest version of the |
Thanks @jnsgruk, all done :) |
All units in a Prometheus app will share the same credentials.
Closing in favour of #28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to juju/juju#15319.
This adds Prometheus integration to the controller charm using
MetricsEndpointProvider
in theprometheus-k8s
library.The controller charm needs to:
TODO