Allow functions config to override the service config #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanjoDiaz
commented
Dec 6, 2018
| return Object.assign({}, defaultOpts, { enabled: possibleConfig }) | ||
| } | ||
|
|
||
| // Keep backwards compatibility for now |
There was a problem hiding this comment.
This is the backward compatibility little hack 😄
There was a problem hiding this comment.
Yes it helps if we don't want to bump major.
|
Wow. It's looking a lot better. I like the structuring and using ternary. Yes we really need to add tests. Should we go about writing tests in this one? Maybe it's the right time. |
|
I'd rather get this merged, do a couple more improvements that I have in mind and then add tests. No need to release right away until we get this, #81 and the tests done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ended up touching too much code for what I wanted to do but the important bits are:
enabled,sourceandsourceRawfrom the servicedefaulttoenabledsince it makes much more sense. I've left a little hack to ensure backward compatibility but I'm happy also removing it and bumping the major version.This enables #81 to set the concurrency inside the
warmupobject.P.S.: We really should add tests. It's a pain to test everything manually... 🙂