Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update descriptions about checkpointing tools and other minor details #87

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

aqjune
Copy link
Contributor

@aqjune aqjune commented Jan 10, 2024

This patch updates README to explain three checkpointing tools that are working as of 2024: DMTCP, CRIU and selfie.
Also, minor details of README are updated and a comment saying that ckpt does not work is added to Makefile.

@aqjune
Copy link
Contributor Author

aqjune commented Jan 10, 2024

To @mpu : I just realized that probably I should have asked first before writing this patch. I found that selfie worked pretty well on my x86-64 machine; I recommended it as one of three options of checkpointing tools. Does it look good or is it better to mention the only two other tools in this document?

README Outdated Show resolved Hide resolved

./dmtcp_restart_script.sh
# #load "selfie.cma";;
# #use "selfie.ml";;
Copy link
Contributor

@mpu mpu Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this #use "selfie.ml";;, rather you just do Selfie.snap "output.img";; below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm, on my ocaml instance I am seeing this error message without #use "selfie.ml";;:

        Camlp5 parsing version 7.10

# #load "selfie.cma";;       
# Selfie.snap "test";;       
File "help.ml" already loaded
Characters 0-11:             
  Selfie.snap "test";;       
  ^^^^^^^^^^^                
Error: Unbound module Selfie 

Would it require additional settings?

@mpu
Copy link
Contributor

mpu commented Jan 11, 2024

@aqjune, no problem! I'm glad somebody else finds selfie useful.

This patch updates README to explain three checkpointing tools that are working
as of 2024: DMTCP, CRIU and selfie.
Also, minor details of README are updated and a comment saying that ckpt does not
work is added to Makefile.
Copy link
Owner

@jrh13 jrh13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, HOL Light now has working and documented
checkpointing, for the first time in many years!

@jrh13 jrh13 merged commit 38dd8a8 into jrh13:master Jan 12, 2024
2 checks passed
@aqjune aqjune deleted the checkpoint branch January 13, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants