xdot/ui/elements: Bugfix: Check if GTK default settings are Null #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When GTK default settings are not present in the system "xdot" fails with the following error: AttributeError: 'NoneType' object has no attribute 'get_property' This is because "Gtk.Settings.get_default()" return value can be "Null" when the GTK default settings are not present (see <https://docs.gtk.org/gtk3/type_func.Settings.get_default.html>.) This patch fixes this error by adding additional check for Null object before setting the default font name. * xdot/ui/elements.py (TextShape): Don't set "DEFAULT_FONTNAME" constant. (TextShape.__init__): Set the default font name as "default_fontname" class field with an additional check for "Null" value. (TextShape._draw): Use "self.default_fontname".
|
Looks good. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When GTK default settings are not present in the system "xdot" fails with the following error:
AttributeError: 'NoneType' object has no attribute 'get_property'
This is because "Gtk.Settings.get_default()" return value can be "Null" when the GTK default settings are not present (see
https://docs.gtk.org/gtk3/type_func.Settings.get_default.html.) This patch fixes this error by adding additional check for Null object before setting the default font name.