Warn on unavailable fonts, fall back onto GTK default font #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #117
This changeset introduces a warning when drawing a graph that contains references to unavailable font families, as well as behavior to fall back onto GTK's default font. I've structured these changes into separate commits in case the fallback behavior is not wanted.
I've tested this on Ubuntu 20.04, where it works, but cannot seem to get a working installation of
xdoton Windows to test it there, probably because I installed GTK4 according to themingwguide, but I thinkxdotrequires GTK3 specifically? I did at least test that thegtk-font-nameproperty is defined and has a sane value on Windows, though.