Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up testing vs linting concepts, plus misc fixes. #127

Merged
merged 2 commits into from
May 20, 2020

Conversation

ceball
Copy link
Collaborator

@ceball ceball commented May 20, 2020

Fix #109:

  • Remove "coverage" as a concept from nbcelltests.lint.
  • Remove "lines_per_cell", "cells_per_notebook", "function_definitions", "class_definitions" as concepts from nbcelltests.test.

Fix #120: test.runWith*() fns were not applying any rules. Also, add some basic/beginning testing of test.runWith()* fns (but see #122)

Also:

@ceball ceball requested a review from vidartf May 20, 2020 14:51
@ceball
Copy link
Collaborator Author

ceball commented May 20, 2020

@vidartf I got distracted and clicked in the wrong place on #124 when I came to merge. Please could you approve this one (it's identical). Thanks!

@ceball ceball merged commit 4e46245 into jpmorganchase:master May 20, 2020
@ceball ceball deleted the clarify_test_and_lint branch May 20, 2020 15:19
ceball added a commit to ceball/nbcelltests that referenced this pull request May 21, 2020
ceball added a commit to ceball/nbcelltests that referenced this pull request May 21, 2020
vidartf added a commit that referenced this pull request May 21, 2020
Clean up: remove code accidentally not removed in #127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rules are not being applied by most test functions Clarify what is linting and what is testing
2 participants