Use unique interface name for tuple requests #30
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if a function has multiple tuple parameters only one Request interface is generated and used for all of them. I haven't tested this change, and not sure how deep tuples are handled but I think something like this should be useful.
|
Hey sorry i missed this.. when would you have a tuple named the same name with different interface? |
|
|
|
Ahhhh I get you have you got an example ABI I can use to do some testing that you have used to verify this change? If not no worries can gen one and test it out |
|
I don't have one, sorry |
|
Scam Comment @joshstevens19 |
Repository owner
deleted a comment
Jan 28, 2024
Repository owner
deleted a comment
Jan 28, 2024
Repository owner
deleted a comment from
chasedson
Feb 7, 2024
Repository owner
deleted a comment
Feb 19, 2024
Repository owner
deleted a comment from
ilkerbrz
Feb 23, 2024
Repository owner
deleted a comment from
yexuanyang
Mar 4, 2024
Repository owner
deleted a comment from
roneyfraga
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a function has multiple tuple parameters only one Request interface is generated and used for all of them.
I haven't tested this change, and not sure how deep tuples are handled but I think something like this should be useful.