fix(web): wrong pass on integration tests #276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plz inform, if have to split in multiple smaller PRs.
See: #275
I think the main problem is, that the failures are caught inside the
gherkin_integration_test_runner
and aren't reported to the integration_test package. So it passes. Why it only happens on web, I don't really know.But for all of the platforms. A scenario should never pass, if one step fails. So I would recommend to simply apply it everywhere, as this should be the final "ultimate" test, even if it does not show the exact step, where it fails. At least the CI never passes a scenario, which has not passed all of its steps, whatever is happening.
Of course one should determine the source of the failure.