Expand state type defintion to accept atoms #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Clean up type definitions - Fix dialyzer errors - Move `t:state()` to Machinery.Transition so there aren't circular deps
There were some type errors that were making calling code give the old "no local return" error. Add dialyzer so this won't happen anymore.
|
@joaomdmoura please let me know if there is anything I can do to make merging this easier for you. |
|
I'm gonna close this to get it out of my feed. @joaomdmoura if you decide to update this library, feel free to re-open it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing changes from #82
I have run into this issue more than once using this library and dialyzer is very mad at me in a current project.