Improve required validator #377

[vasilich6107]

Connection with issue(s)

Close #377

[vasilich6107]

Hi @joanpablo
This is a quick one)

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07 🎉

Comparison is base (59fe334) 95.83% compared to head (330a17b) 95.90%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
+ Coverage   95.83%   95.90%   +0.07%     
==========================================
  Files          65       65              
  Lines        1319     1320       +1     
==========================================
+ Hits         1264     1266       +2     
+ Misses         55       54       -1     

Impacted Files	Coverage Δ
lib/src/validators/required_validator.dart	100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[joanpablo]

Hi @vasilich6107

Thanks for been so diligent and taking care of the comments. In this particular case I'm not sure we want to merge both concepts in the same Validator. You can check my answer in the issue #377

[joanpablo]

Maybe creating another validator that serves as an alias to the Validators.minLength(1), something like Validators.isNotEmpty could work out

[laogao]

Maybe creating another validator that serves as an alias to the Validators.minLength(1), something like Validators.isNotEmpty could work out

There is one caveat for minLength(1), which concerns numbers. I'd much prefer a NonEmptyValidator to an alias to Validators.minLength(1), and "re-use" the ValidationMessage.required key. (See my comment in #377 .)

[vasilich6107]

@joanpablo
no problem

[joanpablo]

I will close this PR since the discussion is still open.