Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace polygon with polygonzkevm #29

Merged
merged 1 commit into from
Mar 23, 2024
Merged

feat: replace polygon with polygonzkevm #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions frontend_v2/pages/_app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ import {
scrollSepolia,
optimism,
optimismSepolia,
polygonMumbai,
polygon,
polygonZkEvm,
polygonZkEvmTestnet,
sepolia,
linea,
lineaTestnet
Expand All @@ -33,8 +33,8 @@ const config = getDefaultConfig({
sepolia,
scroll,
scrollSepolia,
polygon,
polygonMumbai,
polygonZkEvm,
polygonZkEvmTestnet,
Comment on lines +36 to +37
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

Codebase Verification

The verification process has revealed that the renaming effort to include polygonZkEvm and polygonZkEvmTestnet in the chains array of the config object has been successfully applied to frontend_v2/pages/_app.tsx, as described in the PR. However, references to the old network names polygon and polygonMumbai are still present in frontend_v1/src/app/providers.tsx.

This suggests that while the updates are consistent for frontend_v2, the frontend_v1 version of the application has not been similarly updated. Depending on the status and maintenance plan for frontend_v1 (whether it is deprecated, being phased out, or still actively maintained), this may require further action or clarification.

Analysis chain

The inclusion of polygonZkEvm and polygonZkEvmTestnet in the chains array of the config object is consistent with the renaming effort described in the PR. This ensures that the application's configuration correctly references the updated blockchain networks. It's important to verify that other parts of the application that rely on this configuration are also updated to handle these new network references appropriately.

Scripts Executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for references to the old network names to ensure they've been updated.
rg --type tsx 'polygon|polygonMumbai'
# Expecting no results for direct references to the old names.

Length of output: 67

Script:

#!/bin/bash
# Search for references to the old network names to ensure they've been updated, using a glob pattern for .tsx files.
rg 'polygon|polygonMumbai' -g '*.tsx'
# Expecting no results for direct references to the old names.

Length of output: 437

optimism,
optimismSepolia,
linea,
Expand Down
Loading