Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add function description support to FunctionEntry #105

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

eddycharly
Copy link
Collaborator

Add function description support to FunctionEntry.

This will be useful for consumers of the lib to provide documentation around their custom functions.

cc @springcomp

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.85%. Comparing base (e430401) to head (7ab3366).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   88.51%   88.85%   +0.34%     
==========================================
  Files          15       15              
  Lines        2594     2621      +27     
==========================================
+ Hits         2296     2329      +33     
+ Misses        204      200       -4     
+ Partials       94       92       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eddycharly
Copy link
Collaborator Author

@springcomp are you ok with this change ?

@springcomp
Copy link
Contributor

Great idea !

@eddycharly eddycharly merged commit 76ba4b0 into jmespath-community:main Sep 18, 2024
11 checks passed
@eddycharly eddycharly deleted the function-description branch September 18, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants