Raise ArgumentError
if Version
is initialized with a nil
version string
#44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment,
Semantic::Version.new
raises aNoMethodError
exception like this if you try to pass innil
as the version string:This alters the behaviour to raise an
ArgumentError
instead, which is what we do if you pass a malformed string (e.g.dasd
). This is a breaking change to the library's API - but it feels like a more reasonable and unsurprising behaviour.