Fixes #42: Cannot compare Semantic::Version to nil

jlindsey · Jun 21, 2021 · 110cd61 · 110cd61
1 parent 54de37b
commit 110cd61
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/lib/semantic/version.rb b/lib/semantic/version.rb
@@ -81,6 +81,8 @@ def eql? other_version
     end
 
     def <=> other_version
+      raise ArgumentError.new('Expected a type of Semantic::Version for comparison') if other_version.nil?
+
       other_version = Version.new(other_version) if other_version.is_a? String
       [:major, :minor, :patch].each do |part|
         c = (self.send(part) <=> other_version.send(part))

diff --git a/spec/version_spec.rb b/spec/version_spec.rb
@@ -263,6 +263,13 @@
         /should be an array of versions/
       )
     end
+
+    it 'raises an ArugmentError when compared to nil' do
+      expect { @v1_5_9_pre_1 < nil }.to raise_error(ArgumentError)
+      expect { @v1_5_9_pre_1 > nil }.to raise_error(ArgumentError)
+      expect { @v1_5_9_pre_1 == nil }.to raise_error(ArgumentError)
+      expect { @v1_5_9_pre_1 <=> nil }.to raise_error(ArgumentError)
+    end
   end
 
   context 'type coercions' do