Add archive file to cache files that passed checksum validation (#600) #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test_checksum_archive platform-independent
…d in item.py -> Item -> download for checksum_archive
|
I just resolved the merge conflict introduced by #650 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attemp to implement #600.
Instead of using
--checksum, the user can now use--checksum-archive.This will create a file named
_checksum_archive.txtand write a line to it every time a checksum validation succeeds. Subsequent runs will skip the files listed in_checksum_archive.txt.To implement this feature and ensure that the tests related to my changes pass, I had to increase the
max-argsto 24 inpyproject.toml.In conclusion, this solution enhances the efficiency of checksum validations by skipping previously validated files.
I look forward to your feedback and suggestions for any improvements.