First pass at using Last-Modified header to set mtime #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 24, 2023 11:22
ChlodAlejandro
added a commit
to ChlodAlejandro/internetarchive
that referenced
this pull request
May 26, 2024
jjjake#614 moved skip checks to until after response headers have been received, which drastically slows down the download process if the file already exists or the file has an equal checksum. Since the file name and checksum are already known prior to download, these checks should remain at the start to avoid having to make a request which would eventually be discarded anyway.
ChlodAlejandro
added a commit
to ChlodAlejandro/internetarchive
that referenced
this pull request
May 26, 2024
jjjake#614 moved skip checks to until after response headers have been received, which drastically slows down the download process if the file already exists or the file has an equal checksum. Since the file name and checksum are already known prior to download, these checks should remain at the start to avoid having to make a request which would eventually be discarded anyway.
ChlodAlejandro
added a commit
to ChlodAlejandro/internetarchive
that referenced
this pull request
May 26, 2024
jjjake#614 moved skip checks to until after response headers have been received, which drastically slows down the download process if the file already exists or the file has an equal checksum. Since the file name and checksum are already known prior to download, these checks should remain at the start to avoid having to make a request which would eventually be discarded anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in support of setting a valid mtime for files.xml.