Update XcodePostBuild.cs #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves issue related to bug: *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'Storyboard (<UIStoryboard: 0x283e21280>) doesn't contain a view controller with identifier 'unitySplashStoryboard'' This definitely occurs in the 2018 versions. I'm not sure about later 2017 versions.
jiulongw
reviewed
Sep 7, 2018
| @@ -271,6 +271,12 @@ private static void PatchUnityNativeCode(string pathToBuiltProject) | |||
| { | |||
| EditSplashScreenMM(Path.Combine(pathToBuiltProject, "Classes/UI/SplashScreen.mm")); | |||
| } | |||
|
|
|||
| // TODO: There are possibly more versions with this issue. | |||
| if (Application.unityVersion.StartsWith("2018.")) | |||
There was a problem hiding this comment.
I wonder if you simply put this condition into the if condition above, will it still work?
Looking at the function in the issue you mentioned, the logic is pretty similar with 2017.3+ versions. If hasStoryboard is set to false, these storyboards won't conflict with each other, right?
There was a problem hiding this comment.
I'll give it a try this week and report back shortly!
|
Hello, could you try if #104 solved this problem? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue related to bug:
*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'Storyboard (<UIStoryboard: 0x283e21280>) doesn't contain a view controller with identifier 'unitySplashStoryboard''
This definitely occurs in the 2018 versions. I'm not sure about later 2017 versions.