Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom_metric for dynamic batching #6189

Merged
merged 7 commits into from
Sep 18, 2024

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Sep 3, 2024

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

@github-actions github-actions bot added size/M area/core This issue/PR affects the core codebase labels Sep 3, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 5.88235% with 32 lines in your changes missing coverage. Please review.

Project coverage is 50.91%. Comparing base (09f61da) to head (148f40a).
Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
jina/serve/runtimes/worker/batch_queue.py 6.25% 30 Missing ⚠️
jina/serve/executors/decorators.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6189      +/-   ##
==========================================
- Coverage   55.74%   50.91%   -4.83%     
==========================================
  Files         150      150              
  Lines       14144    14215      +71     
==========================================
- Hits         7884     7237     -647     
- Misses       6260     6978     +718     
Flag Coverage Δ
jina 50.91% <5.88%> (-4.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the area/testing This issue/PR affects testing label Sep 18, 2024
@JoanFM JoanFM force-pushed the feat-allow-custom-dyn-batch-size branch from ff91825 to 2d1973d Compare September 18, 2024 14:35
@JoanFM JoanFM marked this pull request as ready for review September 18, 2024 14:39
@JoanFM JoanFM closed this Sep 18, 2024
@JoanFM JoanFM reopened this Sep 18, 2024
@JoanFM JoanFM force-pushed the feat-allow-custom-dyn-batch-size branch from 0ee7825 to e79b3b2 Compare September 18, 2024 14:44
@JoanFM JoanFM force-pushed the feat-allow-custom-dyn-batch-size branch from e79b3b2 to c6470a7 Compare September 18, 2024 15:24
@JoanFM JoanFM merged commit d17b620 into master Sep 18, 2024
129 checks passed
@JoanFM JoanFM deleted the feat-allow-custom-dyn-batch-size branch September 18, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/M size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants