Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use 127.0.0.1 as local ctrl address #6004

Merged
merged 1 commit into from
Aug 2, 2023
Merged

fix: use 127.0.0.1 as local ctrl address #6004

merged 1 commit into from
Aug 2, 2023

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Aug 2, 2023

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase labels Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #6004 (491dd07) into master (4b4c4ac) will decrease coverage by 13.94%.
Report is 7 commits behind head on master.
The diff coverage is 34.30%.

@@             Coverage Diff             @@
##           master    #6004       +/-   ##
===========================================
- Coverage   78.28%   64.35%   -13.94%     
===========================================
  Files         144      144               
  Lines       13587    13780      +193     
===========================================
- Hits        10637     8868     -1769     
- Misses       2950     4912     +1962     
Flag Coverage Δ
jina 64.35% <34.30%> (-13.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
jina/clients/base/http.py 69.23% <0.00%> (-26.39%) ⬇️
jina/clients/request/__init__.py 100.00% <ø> (ø)
...ina/serve/runtimes/gateway/graph/topology_graph.py 70.44% <0.00%> (-6.37%) ⬇️
...ve/runtimes/gateway/http_fastapi_app_docarrayv2.py 0.00% <0.00%> (ø)
jina/serve/runtimes/helper.py 23.33% <0.00%> (-2.11%) ⬇️
jina/serve/stream/__init__.py 86.82% <ø> (-0.60%) ⬇️
jina/types/request/data.py 61.85% <25.00%> (-21.42%) ⬇️
jina/serve/executors/__init__.py 61.70% <35.15%> (-16.29%) ⬇️
jina/clients/mixin.py 59.87% <41.66%> (-36.54%) ⬇️
jina/serve/runtimes/gateway/request_handling.py 77.85% <42.85%> (-13.13%) ⬇️
... and 4 more

... and 61 files with indirect coverage changes

@JoanFM JoanFM merged commit 6fd64da into master Aug 2, 2023
127 of 129 checks passed
@JoanFM JoanFM deleted the fix-ctrl-address branch August 2, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant