Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parameters can be described as Pydantic model for rich schema #6001

Merged
merged 6 commits into from
Aug 1, 2023

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Aug 1, 2023

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

@github-actions github-actions bot added size/M area/core This issue/PR affects the core codebase labels Aug 1, 2023
@JoanFM JoanFM force-pushed the feat-parameters-as-pydantic-model branch from 1958952 to d8b6e82 Compare August 1, 2023 10:12
@JoanFM JoanFM changed the title feat: first iteration having parameters as Pydantic feat: parameters can be described as Pydantic model for rich schema Aug 1, 2023
@JoanFM JoanFM closed this Aug 1, 2023
@JoanFM JoanFM reopened this Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #6001 (b7c4824) into master (4b4c4ac) will decrease coverage by 3.04%.
Report is 4 commits behind head on master.
The diff coverage is 36.86%.

@@            Coverage Diff             @@
##           master    #6001      +/-   ##
==========================================
- Coverage   78.28%   75.25%   -3.04%     
==========================================
  Files         144      144              
  Lines       13587    13781     +194     
==========================================
- Hits        10637    10371     -266     
- Misses       2950     3410     +460     
Flag Coverage Δ
jina 75.25% <36.86%> (-3.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
jina/clients/base/http.py 93.16% <0.00%> (-2.46%) ⬇️
jina/clients/request/__init__.py 100.00% <ø> (ø)
...untimes/gateway/async_request_response_handling.py 91.66% <0.00%> (-1.47%) ⬇️
...ina/serve/runtimes/gateway/graph/topology_graph.py 72.37% <0.00%> (-4.44%) ⬇️
...ve/runtimes/gateway/http_fastapi_app_docarrayv2.py 0.00% <0.00%> (ø)
jina/serve/runtimes/helper.py 24.16% <0.00%> (-1.28%) ⬇️
jina/serve/stream/__init__.py 87.42% <ø> (ø)
jina/types/request/data.py 81.09% <25.00%> (-2.18%) ⬇️
jina/serve/executors/__init__.py 67.83% <35.15%> (-10.17%) ⬇️
jina/clients/mixin.py 89.80% <54.16%> (-6.60%) ⬇️
... and 4 more

... and 19 files with indirect coverage changes

@github-actions github-actions bot added size/L area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping component/type labels Aug 1, 2023
@JoanFM JoanFM closed this Aug 1, 2023
@JoanFM JoanFM reopened this Aug 1, 2023
Signed-off-by: Joan Fontanals Martinez <[email protected]>
@JoanFM JoanFM force-pushed the feat-parameters-as-pydantic-model branch from bb83c97 to 98a6c72 Compare August 1, 2023 12:11
@github-actions github-actions bot added the area/testing This issue/PR affects testing label Aug 1, 2023
@JoanFM JoanFM merged commit 9c0378a into master Aug 1, 2023
127 of 129 checks passed
@JoanFM JoanFM deleted the feat-parameters-as-pydantic-model branch August 1, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping area/testing This issue/PR affects testing component/client component/type size/L size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to define parameters as Pydantic model, so that one can have a reach schema
2 participants