-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: parameters can be described as Pydantic model for rich schema #6001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/M
area/core
This issue/PR affects the core codebase
labels
Aug 1, 2023
Signed-off-by: Joan Fontanals Martinez <[email protected]>
JoanFM
force-pushed
the
feat-parameters-as-pydantic-model
branch
from
August 1, 2023 10:12
1958952
to
d8b6e82
Compare
JoanFM
changed the title
feat: first iteration having parameters as Pydantic
feat: parameters can be described as Pydantic model for rich schema
Aug 1, 2023
Codecov Report
@@ Coverage Diff @@
## master #6001 +/- ##
==========================================
- Coverage 78.28% 75.25% -3.04%
==========================================
Files 144 144
Lines 13587 13781 +194
==========================================
- Hits 10637 10371 -266
- Misses 2950 3410 +460
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…m/jina-ai/jina into feat-parameters-as-pydantic-model
github-actions
bot
added
size/L
area/cicd
This issue/PR affects the cicd pipeline
area/housekeeping
This issue/PR is housekeeping
component/type
labels
Aug 1, 2023
Signed-off-by: Joan Fontanals Martinez <[email protected]>
JoanFM
force-pushed
the
feat-parameters-as-pydantic-model
branch
from
August 1, 2023 12:11
bb83c97
to
98a6c72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/cicd
This issue/PR affects the cicd pipeline
area/core
This issue/PR affects the core codebase
area/housekeeping
This issue/PR is housekeeping
area/testing
This issue/PR affects testing
component/client
component/type
size/L
size/M
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals:
resolves #ISSUE-NUMBER
...
...
...
...
check and update documentation. See guide and ask the team.