Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: executor singleton doc #5991

Merged
merged 18 commits into from
Aug 1, 2023
Merged

feat: executor singleton doc #5991

merged 18 commits into from
Aug 1, 2023

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jul 29, 2023

Allow to serve Executors that run on single BaseDoc and not on DocList

@JoanFM JoanFM linked an issue Jul 29, 2023 that may be closed by this pull request
5 tasks
@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions github-actions bot added area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/proto labels Jul 29, 2023
@JoanFM JoanFM changed the title Feat executor singleton doc feat: executor singleton doc Jul 29, 2023
@JoanFM JoanFM closed this Jul 29, 2023
@JoanFM JoanFM reopened this Jul 29, 2023
@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Merging #5991 (f91cba5) into master (4b4c4ac) will decrease coverage by 18.37%.
Report is 3 commits behind head on master.
The diff coverage is 30.33%.

@@             Coverage Diff             @@
##           master    #5991       +/-   ##
===========================================
- Coverage   78.28%   59.92%   -18.37%     
===========================================
  Files         144      142        -2     
  Lines       13587    13645       +58     
===========================================
- Hits        10637     8177     -2460     
- Misses       2950     5468     +2518     
Flag Coverage Δ
jina 59.92% <30.33%> (-18.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
jina/clients/base/http.py 68.37% <0.00%> (-27.24%) ⬇️
...ina/serve/runtimes/gateway/graph/topology_graph.py 64.36% <0.00%> (-12.45%) ⬇️
...ve/runtimes/gateway/http_fastapi_app_docarrayv2.py 0.00% <0.00%> (ø)
jina/serve/runtimes/helper.py 15.83% <0.00%> (-9.61%) ⬇️
jina/serve/runtimes/worker/http_fastapi_app.py 0.00% <0.00%> (-87.50%) ⬇️
jina/serve/stream/__init__.py 67.66% <ø> (-19.77%) ⬇️
jina/serve/runtimes/gateway/request_handling.py 50.71% <14.28%> (-40.27%) ⬇️
jina/clients/mixin.py 45.22% <33.33%> (-51.18%) ⬇️
jina/serve/executors/__init__.py 56.35% <41.66%> (-21.64%) ⬇️
jina/serve/runtimes/worker/request_handling.py 50.86% <58.33%> (-32.45%) ⬇️
... and 1 more

... and 72 files with indirect coverage changes

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions github-actions bot added the area/testing This issue/PR affects testing label Jul 29, 2023
@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions github-actions bot added size/M and removed component/proto area/network This issue/PR affects network functionality labels Jul 30, 2023
@github-actions github-actions bot added area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Aug 1, 2023
Signed-off-by: Joan Fontanals Martinez <[email protected]>
@JoanFM JoanFM force-pushed the feat-executor-singleton-doc branch from 1991abb to e3056b7 Compare August 1, 2023 03:42
Signed-off-by: Joan Fontanals Martinez <[email protected]>
@JoanFM JoanFM force-pushed the feat-executor-singleton-doc branch from 90ea45f to 1b027d8 Compare August 1, 2023 04:49
Signed-off-by: Joan Fontanals Martinez <[email protected]>
@JoanFM JoanFM force-pushed the feat-executor-singleton-doc branch from 4f3ac7b to f91cba5 Compare August 1, 2023 06:22
@JoanFM JoanFM marked this pull request as ready for review August 1, 2023 06:30
@JoanFM JoanFM merged commit 31fd261 into master Aug 1, 2023
125 of 128 checks passed
@JoanFM JoanFM deleted the feat-executor-singleton-doc branch August 1, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping area/testing This issue/PR affects testing component/client size/L size/M size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow endpoints to work on single BaseDocs.
2 participants