Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unset http proxy #5972

Merged
merged 1 commit into from
Jul 19, 2023
Merged

fix: unset http proxy #5972

merged 1 commit into from
Jul 19, 2023

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jul 18, 2023

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

@JoanFM JoanFM linked an issue Jul 18, 2023 that may be closed by this pull request
@github-actions github-actions bot added the area/core This issue/PR affects the core codebase label Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #5972 (f48d3b2) into master (a8997b6) will increase coverage by 0.73%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5972      +/-   ##
==========================================
+ Coverage   78.37%   79.10%   +0.73%     
==========================================
  Files         144      144              
  Lines       13123    13127       +4     
==========================================
+ Hits        10285    10384      +99     
+ Misses       2838     2743      -95     
Flag Coverage Δ
jina 79.10% <100.00%> (+0.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/serve/runtimes/asyncio.py 87.97% <ø> (ø)
jina/serve/runtimes/servers/grpc.py 90.62% <100.00%> (+1.49%) ⬆️

... and 19 files with indirect coverage changes

Signed-off-by: Joan Fontanals Martinez <[email protected]>
@JoanFM JoanFM merged commit eda0fbb into master Jul 19, 2023
127 of 129 checks passed
@JoanFM JoanFM deleted the unset-http-proxies-grpc branch July 19, 2023 06:50
@JoanFM JoanFM mentioned this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase size/S size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endless Waiting executor0 but the service works normally.
1 participant