Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore warnings from google #5968

Merged
merged 3 commits into from
Jul 30, 2023
Merged

fix: ignore warnings from google #5968

merged 3 commits into from
Jul 30, 2023

Conversation

deepankarm
Copy link
Contributor

Goals:

Before
image

After
image

  • check and update documentation. See guide and ask the team.

@deepankarm deepankarm requested a review from hanxiao as a code owner July 18, 2023 10:57
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality labels Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #5968 (551859d) into master (34664ee) will decrease coverage by 0.59%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #5968      +/-   ##
==========================================
- Coverage   78.03%   77.45%   -0.59%     
==========================================
  Files         144      144              
  Lines       13583    13587       +4     
==========================================
- Hits        10600    10524      -76     
- Misses       2983     3063      +80     
Flag Coverage Δ
jina 77.45% <71.42%> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
jina/__init__.py 56.00% <71.42%> (+2.47%) ⬆️

... and 19 files with indirect coverage changes

@deepankarm deepankarm marked this pull request as draft July 18, 2023 11:50
@deepankarm
Copy link
Contributor Author

Moved to draft as it skips other warnings as well

@JoanFM JoanFM marked this pull request as ready for review July 30, 2023 14:36
@JoanFM JoanFM merged commit 4b4c4ac into master Jul 30, 2023
126 of 128 checks passed
@JoanFM JoanFM deleted the ignore-google-warnings branch July 30, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants