Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: monitoring validation error #5965

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jul 13, 2023

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

jina-bot and others added 2 commits July 13, 2023 19:53
@JoanFM JoanFM linked an issue Jul 13, 2023 that may be closed by this pull request
@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase labels Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #5965 (535f414) into master (8a0280e) will decrease coverage by 3.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5965      +/-   ##
==========================================
- Coverage   79.29%   76.13%   -3.16%     
==========================================
  Files         144      144              
  Lines       13087    13088       +1     
==========================================
- Hits        10377     9965     -412     
- Misses       2710     3123     +413     
Flag Coverage Δ
jina 76.13% <100.00%> (-3.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 53.52% <100.00%> (ø)
jina/serve/runtimes/worker/request_handling.py 82.60% <100.00%> (-1.21%) ⬇️

... and 30 files with indirect coverage changes

@github-actions github-actions bot added size/M area/testing This issue/PR affects testing labels Jul 13, 2023
@JoanFM JoanFM merged commit 242692e into master Jul 13, 2023
125 of 127 checks passed
@JoanFM JoanFM deleted the fix-monitoring-validation-error branch July 13, 2023 18:56
@JoanFM JoanFM mentioned this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/M size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docarray ValidationError when monitoring is enabled
2 participants