-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: properly handle mulitprotocol Deployment to Kubernetes #5961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/XS
area/core
This issue/PR affects the core codebase
labels
Jul 12, 2023
Codecov Report
@@ Coverage Diff @@
## master #5961 +/- ##
==========================================
- Coverage 79.29% 79.20% -0.09%
==========================================
Files 144 144
Lines 13087 13114 +27
==========================================
+ Hits 10377 10387 +10
- Misses 2710 2727 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JoanFM
changed the title
fix: allow usage with ports plural
fix: properly handle mulitprotocol Deployment to Kubernetes
Jul 12, 2023
Signed-off-by: Joan Fontanals Martinez <[email protected]>
JoanFM
force-pushed
the
fix-multiprotocol-k8s
branch
from
July 12, 2023 15:51
fb17879
to
03b54c2
Compare
Signed-off-by: Joan Fontanals Martinez <[email protected]>
… into fix-multiprotocol-k8s
Signed-off-by: Joan Fontanals Martinez <[email protected]>
JoanFM
force-pushed
the
fix-multiprotocol-k8s
branch
from
July 13, 2023 18:40
b7106fc
to
fbd21cb
Compare
Signed-off-by: Joan Fontanals Martinez <[email protected]>
… into fix-multiprotocol-k8s
JoanFM
force-pushed
the
fix-multiprotocol-k8s
branch
from
July 14, 2023 07:55
f364f96
to
4da6635
Compare
github-actions
bot
added
area/cicd
This issue/PR affects the cicd pipeline
area/housekeeping
This issue/PR is housekeeping
labels
Jul 14, 2023
JoanFM
force-pushed
the
fix-multiprotocol-k8s
branch
2 times, most recently
from
July 14, 2023 09:34
ae8a88d
to
b516b1d
Compare
Signed-off-by: Joan Fontanals Martinez <[email protected]>
JoanFM
force-pushed
the
fix-multiprotocol-k8s
branch
from
July 14, 2023 10:37
b516b1d
to
459eb17
Compare
Signed-off-by: Joan Fontanals Martinez <[email protected]>
JoanFM
force-pushed
the
fix-multiprotocol-k8s
branch
from
July 18, 2023 09:35
0d03c67
to
9e89db0
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/cicd
This issue/PR affects the cicd pipeline
area/core
This issue/PR affects the core codebase
area/housekeeping
This issue/PR is housekeeping
area/testing
This issue/PR affects testing
size/M
size/S
size/XS
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals:
resolves #ISSUE-NUMBER
...
...
...
...
check and update documentation. See guide and ask the team.