Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly handle mulitprotocol Deployment to Kubernetes #5961

Merged
merged 12 commits into from
Jul 18, 2023

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jul 12, 2023

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

@JoanFM JoanFM linked an issue Jul 12, 2023 that may be closed by this pull request
@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase labels Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #5961 (9e89db0) into master (8a0280e) will decrease coverage by 0.09%.
The diff coverage is 67.92%.

@@            Coverage Diff             @@
##           master    #5961      +/-   ##
==========================================
- Coverage   79.29%   79.20%   -0.09%     
==========================================
  Files         144      144              
  Lines       13087    13114      +27     
==========================================
+ Hits        10377    10387      +10     
- Misses       2710     2727      +17     
Flag Coverage Δ
jina 79.20% <67.92%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/serve/executors/__init__.py 79.53% <11.76%> (-2.84%) ⬇️
jina/orchestrate/deployments/__init__.py 82.40% <66.66%> (-0.19%) ⬇️
jina/__init__.py 53.52% <100.00%> (ø)
jina/orchestrate/deployments/config/k8s.py 100.00% <100.00%> (ø)
...deployments/config/k8slib/kubernetes_deployment.py 63.01% <100.00%> (-0.99%) ⬇️
jina/orchestrate/flow/base.py 90.21% <100.00%> (+0.18%) ⬆️
jina/serve/networking/__init__.py 95.09% <100.00%> (ø)
jina/serve/runtimes/asyncio.py 87.97% <100.00%> (ø)
jina/serve/runtimes/worker/request_handling.py 83.85% <100.00%> (+0.03%) ⬆️

... and 4 files with indirect coverage changes

@JoanFM JoanFM changed the title fix: allow usage with ports plural fix: properly handle mulitprotocol Deployment to Kubernetes Jul 12, 2023
@JoanFM JoanFM closed this Jul 13, 2023
@JoanFM JoanFM reopened this Jul 13, 2023
@JoanFM JoanFM closed this Jul 13, 2023
@JoanFM JoanFM reopened this Jul 13, 2023
@github-actions github-actions bot added the area/testing This issue/PR affects testing label Jul 13, 2023
Signed-off-by: Joan Fontanals Martinez <[email protected]>
@github-actions github-actions bot added area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Jul 14, 2023
@JoanFM JoanFM force-pushed the fix-multiprotocol-k8s branch 2 times, most recently from ae8a88d to b516b1d Compare July 14, 2023 09:34
Signed-off-by: Joan Fontanals Martinez <[email protected]>
Signed-off-by: Joan Fontanals Martinez <[email protected]>
@JoanFM JoanFM marked this pull request as ready for review July 18, 2023 10:14
@JoanFM JoanFM merged commit 9cb5f10 into master Jul 18, 2023
125 of 129 checks passed
@JoanFM JoanFM deleted the fix-multiprotocol-k8s branch July 18, 2023 10:14
@JoanFM JoanFM mentioned this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/core This issue/PR affects the core codebase area/housekeeping This issue/PR is housekeeping area/testing This issue/PR affects testing size/M size/S size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable Kubernetes transformation for multiprotocol deployments
2 participants