Support cppdialect/cdialect and some other opts #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarod42
requested changes
Jul 7, 2023
| @@ -232,6 +232,19 @@ local function getcflags(toolset, cfg, filecfg) | |||
| local includes = ninja.list(toolset.getincludedirs(cfg, filecfg.includedirs, filecfg.externalincludedirs, filecfg.frameworkdirs, filecfg.includedirsafter)) | |||
| local forceincludes = ninja.list(toolset.getforceincludes(cfg)) | |||
|
|
|||
| local extra = "" | |||
| if toolset == p.tools.msc then | |||
There was a problem hiding this comment.
Should not be in premake-ninja but in premake core in msc.lua
I already create premake/premake-core#2081 which should fix c(pp)dialect
| extra = extra .. " /openmp" | ||
| end | ||
| end | ||
|
|
||
| return buildopt .. cppflags .. cflags .. defines .. includes .. forceincludes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically equivalent of this code when using Makefile: https://github.com/premake/premake-core/blob/3df1efce5e7c4399eb50f042c2a386ccde64ab62/modules/vstudio/vs2010_vcxproj.lua#L1628-L1658
Finding the piece of code linked above gives me some peace of mind that there aren't many other compile options that are missed anymore (those here are missing, because they'd normally go as solution param with MSBuild...)
Also btw I'll be adding tests to my changes after I'm done wit all my PRs, which is after my msbuild project compiles with this thing as well...