Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bottomBar 구현, topBar 수정 #8

Merged
merged 7 commits into from
Jul 7, 2023
Merged

bottomBar 구현, topBar 수정 #8

merged 7 commits into from
Jul 7, 2023

Commits on Jul 4, 2023

  1. Create feature-home module

    @jhg3410
    jhg3410 committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    ad4054f View commit details
    Browse the repository at this point in the history

  2. Apply bottomBar (design not yet)

    @jhg3410
    jhg3410 committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    342fb09 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Create Custom BottomBar 

    why use Spacer in installScreen
- BottomBar 에 top Corner 존재
- 그렇기에 content 가 BottomBar 위로 올라오기보단, corner size 까지는 포함해야 한다 생각
- 그래야 corner 부분이 자연스러움
- 하지만 그러면 Content 의 최하단이 가려질 수 있음(corner size 만큼)
- 그렇기에 Content 들의 하단에 corner size 만큼 Spacer 부여
    @jhg3410
    jhg3410 committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    431696e View commit details
    Browse the repository at this point in the history

  2. Change BottomBar Design 

    - size down
- scale animation when pressed
- change design based on selected or unselected
  - Icon and Color
    @jhg3410
    jhg3410 committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    cd0c63d View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Expand TopBar when Navigate to HomeScreen from PopularScreen

    @jhg3410
    jhg3410 committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    82c824d View commit details
    Browse the repository at this point in the history

  2. Refactor Navigation related codes, Change TopBar title

    @jhg3410
    jhg3410 committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    1a45925 View commit details
    Browse the repository at this point in the history

  3. Remove TopBar from Scaffold, so that each screen has a TopBar

    @jhg3410
    jhg3410 committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    6221e4e View commit details
    Browse the repository at this point in the history