Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PopularScreen-> DetailScreen 전환 구현 #6

Merged
merged 6 commits into from
Jun 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,12 @@ dependencies {
implementation(projects.coreModel)
implementation(projects.coreData)
implementation(projects.featurePopular)
implementation(projects.featureDetail)

implementation(libs.androidx.ktx)
implementation(libs.androidx.runtime.ktx)
implementation(libs.androidx.activity)
implementation(libs.androidx.navigation)

// compose
implementation(libs.compose.ui)
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
xmlns:tools="http://schemas.android.com/tools">

<application
android:name=".MovieApp"
android:name=".MovieApplication"
android:allowBackup="true"
android:dataExtractionRules="@xml/data_extraction_rules"
android:fullBackupContent="@xml/backup_rules"
Expand Down
34 changes: 4 additions & 30 deletions app/src/main/java/com/jik/movie/MainActivity.kt
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,9 @@ package com.jik.movie
import android.os.Bundle
import androidx.activity.ComponentActivity
import androidx.activity.compose.setContent
import androidx.compose.foundation.layout.padding
import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.Scaffold
import androidx.compose.material3.TopAppBarDefaults
import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
import androidx.compose.ui.input.nestedscroll.nestedScroll
import com.jik.core.designsystem.component.MovieTopAppBar
import com.jik.core.designsystem.theme.MovieTheme
import com.jik.feature.popular.PopularScreen
import com.jik.movie.splash.createSplashScreen
import com.jik.movie.ui.MovieApp
import dagger.hilt.android.AndroidEntryPoint
import kotlinx.coroutines.*
import kotlin.time.Duration.Companion.seconds

@AndroidEntryPoint
Expand All @@ -24,24 +15,7 @@ class MainActivity : ComponentActivity() {

super.onCreate(savedInstanceState)
setContent {
MovieTheme(
dynamicColor = false
) {
MovieScreen()
}
MovieApp()
}
}
}

@OptIn(ExperimentalMaterial3Api::class)
@Composable
fun MovieScreen() {
val scrollBehavior = TopAppBarDefaults.enterAlwaysScrollBehavior()

Scaffold(
modifier = Modifier.nestedScroll(scrollBehavior.nestedScrollConnection),
topBar = { MovieTopAppBar(titleRes = R.string.app_name, scrollBehavior = scrollBehavior) }
) {
PopularScreen(Modifier.padding(it))
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ import dagger.hilt.android.HiltAndroidApp


@HiltAndroidApp
class MovieApp : Application()
class MovieApplication : Application()
25 changes: 25 additions & 0 deletions app/src/main/java/com/jik/movie/navigation/MovieNavHost.kt
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
package com.jik.movie.navigation

import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
import androidx.navigation.NavHostController
import androidx.navigation.compose.NavHost
import com.jik.feature.detail.navigation.DetailNavigation.installDetailScreen
import com.jik.feature.popular.navigation.PopularNavigation
import com.jik.feature.popular.navigation.PopularNavigation.installPopularScreen

@Composable
fun MovieNavHost(
navController: NavHostController,
modifier: Modifier = Modifier,
startDestination: String = PopularNavigation.route
) {
NavHost(
navController = navController,
startDestination = startDestination,
modifier = modifier
) {
installPopularScreen(navController)
installDetailScreen()
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package com.jik.movie.navigation

import com.jik.feature.popular.navigation.PopularNavigation

enum class TopLevelDestination(
val route: String
) {
POPULAR(PopularNavigation.route)
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.jik.movie
package com.jik.movie.splash

import android.app.Activity
import androidx.core.splashscreen.SplashScreen.Companion.installSplashScreen
Expand Down
37 changes: 37 additions & 0 deletions app/src/main/java/com/jik/movie/ui/MovieApp.kt
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
package com.jik.movie.ui

import androidx.compose.foundation.layout.padding
import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.Scaffold
import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
import androidx.compose.ui.input.nestedscroll.nestedScroll
import com.jik.core.designsystem.component.MovieTopAppBar
import com.jik.core.designsystem.theme.MovieTheme
import com.jik.core.ui.R
import com.jik.movie.navigation.MovieNavHost

@OptIn(ExperimentalMaterial3Api::class)
@Composable
fun MovieApp() {
MovieTheme(
dynamicColor = false
) {
val appState = rememberMovieAppState()
val scrollBehavior = appState.topAppBarScrollBehavior

Scaffold(
modifier = Modifier.nestedScroll(scrollBehavior.nestedScrollConnection),
topBar = {
if (appState.isTopLevelDestination) {
MovieTopAppBar(
titleRes = R.string.app_name,
scrollBehavior = scrollBehavior
)
}
}
) {
MovieNavHost(navController = appState.navController, modifier = Modifier.padding(it))
}
}
}
38 changes: 38 additions & 0 deletions app/src/main/java/com/jik/movie/ui/MovieAppState.kt
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
package com.jik.movie.ui

import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.TopAppBarDefaults
import androidx.compose.runtime.Composable
import androidx.compose.runtime.Stable
import androidx.compose.runtime.remember
import androidx.navigation.NavHostController
import androidx.navigation.compose.currentBackStackEntryAsState
import androidx.navigation.compose.rememberNavController
import com.jik.movie.navigation.TopLevelDestination

@Composable
fun rememberMovieAppState(
navController: NavHostController = rememberNavController(),
): MovieAppState = remember(navController) {
MovieAppState(
navController = navController,
)
}


@Stable
class MovieAppState(
val navController: NavHostController,
) {

private val topLevelDestinationRoutes = TopLevelDestination.values().map { it.route }


@OptIn(ExperimentalMaterial3Api::class)
val topAppBarScrollBehavior
@Composable get() = TopAppBarDefaults.enterAlwaysScrollBehavior()

val isTopLevelDestination: Boolean
@Composable get() = navController
.currentBackStackEntryAsState().value?.destination?.route in topLevelDestinationRoutes
}
10 changes: 0 additions & 10 deletions app/src/main/res/values/colors.xml

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>

<string name="app_name">Movie</string>
</resources>
1 change: 1 addition & 0 deletions feature-detail/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/build
83 changes: 83 additions & 0 deletions feature-detail/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
@Suppress("DSL_SCOPE_VIOLATION")
plugins {
alias(libs.plugins.android.library)
alias(libs.plugins.kotlin.android)
alias(libs.plugins.kotlin.kapt)
id("dagger.hilt.android.plugin")
}

android {
namespace = "com.jik.feature.detail"
compileSdk = 33

defaultConfig {
minSdk = 24
targetSdk = 33

testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
consumerProguardFiles("consumer-rules.pro")
}

buildTypes {
release {
isMinifyEnabled = false
proguardFiles(
getDefaultProguardFile("proguard-android-optimize.txt"),
"proguard-rules.pro"
)
}
}
compileOptions {
sourceCompatibility = JavaVersion.VERSION_1_8
targetCompatibility = JavaVersion.VERSION_1_8
}
kotlinOptions {
jvmTarget = "1.8"
}
buildFeatures {
compose = true
}
composeOptions {
kotlinCompilerExtensionVersion = "1.4.3"
}
}

dependencies {

// modules
implementation(projects.coreDesignsystem)
implementation(projects.coreUi)
implementation(projects.coreModel)
implementation(projects.coreData)

implementation(libs.androidx.ktx)
implementation(libs.androidx.runtime.ktx)
implementation(libs.androidx.activity)
implementation(libs.androidx.navigation)

// compose
implementation(libs.compose.ui)
implementation(libs.compose.preview)
implementation(libs.compose.material3)

// lifecycle
implementation(libs.lifecycle.viewmodel)
implementation(libs.lifecycle.runtime)

// hilt
implementation(libs.hilt.android)
implementation(libs.hilt.navigation)
kapt(libs.hilt.compiler)

// test
testImplementation(libs.junit)

// android test
androidTestImplementation(libs.ext.junit)
androidTestImplementation(libs.espresso)
androidTestImplementation(libs.compose.test.junit)

// debug
debugImplementation(libs.compose.tooling)
debugImplementation(libs.compose.test.manifest)
}
Empty file.
21 changes: 21 additions & 0 deletions feature-detail/proguard-rules.pro
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# Add project specific ProGuard rules here.
# You can control the set of applied configuration files using the
# proguardFiles setting in build.gradle.
#
# For more details, see
# http://developer.android.com/guide/developing/tools/proguard.html

# If your project uses WebView with JS, uncomment the following
# and specify the fully qualified class name to the JavaScript interface
# class:
#-keepclassmembers class fqcn.of.javascript.interface.for.webview {
# public *;
#}

# Uncomment this to preserve the line number information for
# debugging stack traces.
#-keepattributes SourceFile,LineNumberTable

# If you keep the line number information, uncomment this to
# hide the original source file name.
#-renamesourcefileattribute SourceFile
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
package com.jik.feature.detail

import androidx.test.platform.app.InstrumentationRegistry
import androidx.test.ext.junit.runners.AndroidJUnit4

import org.junit.Test
import org.junit.runner.RunWith

import org.junit.Assert.*

/**
* Instrumented test, which will execute on an Android device.
*
* See [testing documentation](http://d.android.com/tools/testing).
*/
@RunWith(AndroidJUnit4::class)
class ExampleInstrumentedTest {
@Test
fun useAppContext() {
// Context of the app under test.
val appContext = InstrumentationRegistry.getInstrumentation().targetContext
assertEquals("com.jik.feature.detail.test", appContext.packageName)
}
}
4 changes: 4 additions & 0 deletions feature-detail/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android">

</manifest>
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
package com.jik.feature.detail

import androidx.compose.foundation.layout.Box
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
import androidx.hilt.navigation.compose.hiltViewModel


@Composable
fun DetailScreen(
movieId: Long,
modifier: Modifier = Modifier,
viewModel: DetailViewModel = hiltViewModel()
) {


Box(modifier = modifier) {
Text(
text = "Detail Screen${movieId}",
style = MaterialTheme.typography.titleLarge,
color = MaterialTheme.colorScheme.primary
)
}
}
Loading