Skip to content

Commit

Permalink
Remove TODO for features not to be implemented yet
Browse files Browse the repository at this point in the history
  • Loading branch information
jhendersonHDF committed Jun 28, 2024
1 parent 5d24f12 commit 276d780
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 28 deletions.
30 changes: 6 additions & 24 deletions src/H5Znbit.c
Original file line number Diff line number Diff line change
Expand Up @@ -239,17 +239,14 @@ H5Z__calc_parms_array(const H5T_t *type, size_t *cd_values_actual_nparms)
HGOTO_ERROR(H5E_PLINE, H5E_BADTYPE, FAIL, "nbit cannot compute parameters for datatype");
break;

case H5T_COMPLEX:
/* TODO */
break;

case H5T_TIME:
case H5T_STRING:
case H5T_BITFIELD:
case H5T_OPAQUE:
case H5T_REFERENCE:
case H5T_ENUM:
case H5T_VLEN:
case H5T_COMPLEX:
/* Other datatype classes: nbit does no compression */
H5Z__calc_parms_nooptype(cd_values_actual_nparms);
break;
Expand Down Expand Up @@ -337,17 +334,14 @@ H5Z__calc_parms_compound(const H5T_t *type, size_t *cd_values_actual_nparms)
HGOTO_ERROR(H5E_PLINE, H5E_BADTYPE, FAIL, "nbit cannot compute parameters for datatype");
break;

case H5T_COMPLEX:
/* TODO */
break;

case H5T_TIME:
case H5T_STRING:
case H5T_BITFIELD:
case H5T_OPAQUE:
case H5T_REFERENCE:
case H5T_ENUM:
case H5T_VLEN:
case H5T_COMPLEX:
/* Other datatype classes: nbit does no compression */
H5Z__calc_parms_nooptype(cd_values_actual_nparms);
break;
Expand Down Expand Up @@ -572,16 +566,13 @@ H5Z__set_parms_array(const H5T_t *type, unsigned *cd_values_index, unsigned cd_v
HGOTO_ERROR(H5E_PLINE, H5E_BADTYPE, FAIL, "nbit cannot set parameters for datatype");
break;

case H5T_COMPLEX:
/* TODO */
break;

case H5T_TIME:
case H5T_STRING:
case H5T_BITFIELD:
case H5T_OPAQUE:
case H5T_REFERENCE:
case H5T_ENUM:
case H5T_COMPLEX:
if (H5Z__set_parms_nooptype(dtype_base, cd_values_index, cd_values) < 0)
HGOTO_ERROR(H5E_PLINE, H5E_BADTYPE, FAIL, "nbit cannot set parameters for datatype");
break;
Expand Down Expand Up @@ -713,16 +704,13 @@ H5Z__set_parms_compound(const H5T_t *type, unsigned *cd_values_index, unsigned c
}
break;

case H5T_COMPLEX:
/* TODO */
break;

case H5T_TIME:
case H5T_STRING:
case H5T_BITFIELD:
case H5T_OPAQUE:
case H5T_REFERENCE:
case H5T_ENUM:
case H5T_COMPLEX:
/* other datatype that nbit does no compression */
if (H5Z__set_parms_nooptype(dtype_member, cd_values_index, cd_values) < 0)
HGOTO_ERROR(H5E_PLINE, H5E_BADTYPE, FAIL, "nbit cannot set parameters for datatype");
Expand Down Expand Up @@ -809,17 +797,14 @@ H5Z__set_local_nbit(hid_t dcpl_id, hid_t type_id, hid_t space_id)
HGOTO_ERROR(H5E_PLINE, H5E_BADTYPE, FAIL, "nbit cannot compute parameters for datatype");
break;

case H5T_COMPLEX:
/* TODO */
break;

case H5T_TIME:
case H5T_STRING:
case H5T_BITFIELD:
case H5T_OPAQUE:
case H5T_REFERENCE:
case H5T_ENUM:
case H5T_VLEN:
case H5T_COMPLEX:
/* No need to calculate other datatypes at top level */
break;

Expand Down Expand Up @@ -885,17 +870,14 @@ H5Z__set_local_nbit(hid_t dcpl_id, hid_t type_id, hid_t space_id)
HGOTO_ERROR(H5E_PLINE, H5E_BADTYPE, FAIL, "nbit cannot set parameters for datatype");
break;

case H5T_COMPLEX:
/* TODO */
break;

case H5T_TIME:
case H5T_STRING:
case H5T_BITFIELD:
case H5T_OPAQUE:
case H5T_REFERENCE:
case H5T_ENUM:
case H5T_VLEN:
case H5T_COMPLEX:
/* No need to set parameters for other datatypes at top level */
break;

Expand Down
5 changes: 1 addition & 4 deletions src/H5Zscaleoffset.c
Original file line number Diff line number Diff line change
Expand Up @@ -978,10 +978,6 @@ H5Z__set_local_scaleoffset(hid_t dcpl_id, hid_t type_id, hid_t space_id)
cd_values[H5Z_SCALEOFFSET_PARM_CLASS] = H5Z_SCALEOFFSET_CLS_FLOAT;
break;

case H5T_COMPLEX:
/* TODO */
break;

case H5T_NO_CLASS:
case H5T_TIME:
case H5T_STRING:
Expand All @@ -992,6 +988,7 @@ H5Z__set_local_scaleoffset(hid_t dcpl_id, hid_t type_id, hid_t space_id)
case H5T_ENUM:
case H5T_VLEN:
case H5T_ARRAY:
case H5T_COMPLEX:
case H5T_NCLASSES:
default:
HGOTO_ERROR(H5E_PLINE, H5E_BADTYPE, FAIL, "datatype class not supported by scaleoffset");
Expand Down

0 comments on commit 276d780

Please sign in to comment.