Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs when working with JRebel #51

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

alex-lx
Copy link

@alex-lx alex-lx commented Mar 9, 2019

Ignore JRebel inserted methods in getMemberRef
Resolve issue: #50

@codecov-io
Copy link

codecov-io commented Apr 26, 2019

Codecov Report

Merging #51 into master will decrease coverage by 1.64%.
The diff coverage is 20%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #51      +/-   ##
============================================
- Coverage     76.71%   75.07%   -1.65%     
- Complexity      105      106       +1     
============================================
  Files             2        2              
  Lines           335      345      +10     
  Branches         98      100       +2     
============================================
+ Hits            257      259       +2     
- Misses           34       40       +6     
- Partials         44       46       +2
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/net/jodah/typetools/TypeResolver.java 78.14% <20%> (-2%) 98 <1> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bd6f1f...94e2c7d. Read the comment docs.

@jhalterman
Copy link
Owner

I realize this might be better if it's a configuration, so that we don't have to hardcode JRebel things that might change, instead JRebel users can configure them. Ex:

// Filters methods that might be matched when resolving lambda type arguments
TypeResolver.addLambdaMemberFilter(Predicate<Member> lambdaMemberFilter)

Thoughts?

@alex-lx
Copy link
Author

alex-lx commented Apr 27, 2019

Got it. I've added the addLambdaMemberFilter method to make the client add a custom filter.

PTAL

The CI failed cause by install-jdk.sh, would you like to check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants