Fix generic extractor #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `-J` options `generic` extractor may return *nonflat* `formats` field every format as separate videos. `-j` option *flatten* all formats together.
Some extractors may also return `null` value. See [1][1]. [1]: ytdl-org/youtube-dl#27679
On some sites `youtube-dl` cannot fetch width/height and returns `nil`. This breaks sorting. Now 1 used as default value as neutral multiplication element.
Some sites cannot stream audio and video separately. Because of that, every change of format with causes fullbacking to `best`, which is not intended. Current fallback option is best, because it also guaranteed to work, because it manually retrieved.
In the previous commit, I too lightly discarded the constant that played the role of *default-case*. I return it and apologize.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried using this plugin with anything other than YouTube and found a few problem areas. Hope you find these edits helpful. I've mostly researched
gerenicextractor, but hopefully this helps with other problems (#19, #16, #8, #5, #4) as well.Thanks for creation of this useful script!