Add MyJFrog IP allowlist resource #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new provider config attribute for MyJFrog API token Add MyJFrogClient to provider metadata
Use correct hostname for API
Improve handling of different error types
Use server name for import test
Use consolidated CheckArtifactoryLicense func
alexhung
force-pushed
the
GH-27-add-ip-allow-list-resource
branch
from
99c753a
to
1484680
Compare
danielmkn
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #27
Acceptance tests can only be executed with SaaS instance with MyJFrog configured. CI/CD will skip this acceptance test.
Also MyJFrog has 5 req/hour rate limit which adds to the testing challenge!