Add OIDC support #47
Merged
Add OIDC support #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add OIDC identity mapping import
Update documentation
danielmkn
previously approved these changes
Mar 25, 2024
Switch it from object type to plain string type and let users use encodejson() to define the correct JSON.
oxdef
reviewed
Mar 26, 2024
| Required: | ||
|
|
||
| - `scope` (String) Scope of the token. You can use `applied-permissions/user`, `applied-permissions/admin`, or `applied-permissions/group`. | ||
| - `username` (String) User name of the OIDC user. |
There was a problem hiding this comment.
Thanks for this PR!
At present in JFrog UI it is possible to specify a list of groups when applied-permissions/group is selected, e.g. see JFrog CLI GitHub Action configuration. It would be really nice to have it here as well so it is possible to utilize access tokens for Non-existing Users feature.
There was a problem hiding this comment.
@oxdef Thanks for the suggestion. I'll update the PR today with support for groups.
Make 'priority' a required attribute Make 'username' an optional attribute Improve documentation
Fix typo in test name
danielmkn
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #26, #29, #31, #38
platform_oidc_configurationandplatform_oidc_identity_mappingresources.