Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for Java and fixes to support Java #28

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Conversation

anchouls
Copy link
Contributor

@anchouls anchouls commented Dec 19, 2023

I redefined the constructors so as not to write unnecessary arguments in Java tests: in class TestMethod we don't need returnType: TestKotlinType? and hasGeneratedPartInName, in class TestVariable we don't need kotlinType and we use argument isFinal to determine argument mutability, I also redefined another constructor for the case when the variable is an argument and we only need the name and javaType.

Copy link
Collaborator

@nbirillo nbirillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one concern about this update, could you please check if I am worng?

@nbirillo nbirillo merged commit 24a48f7 into main Dec 20, 2023
2 checks passed
@nbirillo nbirillo deleted the core-module-for-java branch December 20, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants