Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Test findMethodsWhereMethodIsCalled #19

Merged
merged 4 commits into from
Jul 28, 2023
Merged

Added Test findMethodsWhereMethodIsCalled #19

merged 4 commits into from
Jul 28, 2023

Conversation

anchouls
Copy link
Contributor

No description provided.

@anchouls anchouls requested a review from onewhl July 25, 2023 11:01
onewhl
onewhl requested changes Jul 26, 2023
View reviewed changes
Copy link

@onewhl onewhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anchouls thanks! Please, take a look at the comment

ij/src/main/kotlin/org/jetbrains/academy/test/system/ij/analyzer/IjCodeAnalyzerUtil.kt Outdated Show resolved Hide resolved
@anchouls anchouls requested a review from onewhl July 26, 2023 12:19
@onewhl
Copy link

onewhl commented Jul 27, 2023

@anchouls looks good to me! @GirZ0n could you please take a look at it?

GirZ0n
GirZ0n requested changes Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@GirZ0n GirZ0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Also, please resolve the conflicts

ij/src/main/kotlin/org/jetbrains/academy/test/system/ij/analyzer/IjCodeAnalyzerUtil.kt Outdated Show resolved Hide resolved
ij/src/test/kotlin/org/jetbrains/academy/test/system/ij/formatting/BaseIjTestClassTests.kt Show resolved Hide resolved
@anchouls anchouls force-pushed the anchouls/test-find-methods-where-method-is-called branch from 9416cc0 to 6b43be9 Compare July 27, 2023 16:34
GirZ0n
GirZ0n approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@GirZ0n GirZ0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you :-)

@onewhl onewhl merged commit 268aa88 into main Jul 28, 2023
2 checks passed
@GirZ0n GirZ0n deleted the anchouls/test-find-methods-where-method-is-called branch July 28, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onewhl onewhl onewhl approved these changes

@GirZ0n GirZ0n GirZ0n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anchouls @onewhl @GirZ0n