Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sofia/fix some tests #137

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Sofia/fix some tests #137

wants to merge 10 commits into from

Conversation

sofiiako
Copy link
Contributor

No description provided.

Copy link
Contributor

@Geravant Geravant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The test suit for this task is analyzing output in a particular order. If you add or remove print statements, it might assess your progress incorrectly. In this case, try resetting the task and keep the initial print statements in place." ... or something like that?

@@ -8,4 +8,6 @@ of `or` is `True`. The boolean operator `not` inverts the boolean expression it
Write an expression that evaluates to `True` if `name` is equal to `"John"` and
he is `16` or older.

Please do not add or remove any lines from the code.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like too strict instruction.
Maybe something like "...do not add any print statements not related to the task?"

@@ -29,4 +29,6 @@ Add Jared's (`"Jared"`) number `570` to the phone book.
Remove Gerard's number from the phone book.
Print Jane's phone number from the `phone_book`.

Please do not add or remove any lines from the code.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, let's think of a less restrictive wording

@@ -7,6 +7,7 @@ item. You can apply `in` to lists or dictionaries the same way you did it with s
2) Check if the dictionary contains `"basil"`.

Please complete the task in the specified order.
Please do not add or remove any lines from the code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's think of a less restrictive wording as well

@@ -38,5 +38,7 @@ Assign a value to the `joined` variable such that the `print` statement prints
I like apples and I like bananas and I like peaches and I like grapes
```

Please do not add or remove any lines from the code.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's think of a less restrictive wording as well

@@ -9,4 +9,6 @@ animals[:] = []

Make all `animals` elephants by replacing the last two items.

Please do not add or remove any lines from the code.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's think of a less restrictive wording as well

def test_0_code_len(self):
with open("string_multiplication.py", "r") as taskfile:
lines = taskfile.readlines()
self.assertTrue(len(lines) == 3, msg="Please do not add or remove any lines from the code file.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's think of a less restrictive wording as well

def test_0_code_len(self):
with open("negative_indexing.py", "r") as taskfile:
lines = taskfile.readlines()
self.assertTrue(len(lines) == 3, msg="Please do not add or remove any lines from the code file.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's think of a less restrictive wording as well

@@ -26,4 +26,6 @@ str[:] # a copy of the whole array

Use slicing to get `"Python"` from the `monty_python` variable.

Please do not add or remove any lines from the code.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's think of a less restrictive wording as well

def test_0_code_len(self):
with open("slicing.py", "r") as taskfile:
lines = taskfile.readlines()
self.assertTrue(len(lines) == 6, msg="Please do not add or remove any lines from the code file.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's think of a less restrictive wording as well

def test_0_code_len(self):
with open("type_cast.py", "r") as taskfile:
lines = taskfile.readlines()
self.assertTrue(len(lines) == 10, msg="Please do not add or remove any lines from the code file.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's think of a less restrictive wording as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants