feat!(CosmosStore): Azure.Cosmos 'V4' support / enable mocking Cosmos APIs #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartelink
force-pushed
the
master
branch
2 times, most recently
from
c631161
to
7412990
Compare
…tch Container to CosmosContainer and Database to CosmosDatabase
bartelink
force-pushed
the
cosmossdk4
branch
from
988a0b4
to
a36e742
Compare
bartelink
commented
Feb 19, 2020
bartelink
force-pushed
the
master
branch
9 times, most recently
from
22cfdd4
to
644aaa2
Compare
1 task
bartelink
force-pushed
the
master
branch
2 times, most recently
from
b1a5694
to
a7486eb
Compare
bartelink
force-pushed
the
master
branch
2 times, most recently
from
1919c31
to
b7e2207
Compare
bartelink
force-pushed
the
master
branch
2 times, most recently
from
fe2af41
to
edda98d
Compare
bartelink
changed the title
bartelink
changed the title
bartelink
force-pushed
the
master
branch
5 times, most recently
from
7053335
to
07a8d79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes
master(which uses Cosmos SDK v3 (Microsoft.Azure.Cosmos) + makes it use V4 (Azure.Cosmos)The diffs are fairly large between current
masterand the base of this PR; main reason being that Equinox.CosmosStore has cherry-picked the usage of System.Text.Json, leaving only two interesting facilities:Azure.CosmospackageSystem.Text.Jsonfailwith "TODO"reeqx dumpfunctionalityEquinox.CosmosStore(withCosmosStoreConnection/Context/Category)FsCodec.SystemTextJsonandFsCodec.NewtonsoftJsonFsCodec.SystemTextJsonbeta so we don't end up having a beta release depending on analphaof somethingCancellationTokenparametersCosmosContainerAdapterand any other desired changesdotnet-templatesInvestigate RU consumption discrepancies first observed in Port to Azure.Cosmos / v3 SDK #144 - atm there can be a 10% RU consumption increase, which seems (NOTE: wild speculation) to correlate with a lack of anticipated perf improvements when dealing with large spans of small events[masternow as correct RU consumption using V3] now has correct RU consumption(Reinstate CheckpointAsync Azure/azure-cosmos-dotnet-v3#616 (comment)), so there's reason to believe that this will eventually be righted in the V4 SDK too