Upgrade postcss to ^8.4.31 #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefansundin
commented
Oct 20, 2023
| module.exports = postcss.plugin('postcss-rem-to-pixel', function (options) { | ||
|
|
||
| var opts = objectAssign({}, defaults, options); | ||
| module.exports = function (options) { |
There was a problem hiding this comment.
This fixes this deprecation warning:
postcss-rem-to-pixel: postcss.plugin was deprecated. Migration guide:
https://evilmartians.com/chronicles/postcss-8-plugin-migration
stefansundin
commented
Oct 20, 2023
| @@ -26,7 +26,6 @@ | |||
| "postcss-plugin" | |||
| ], | |||
| "dependencies": { | |||
| "object-assign": "^4.1.0", | |||
| "postcss": "^5.2.10" | |||
| "postcss": "^8.4.31" | |||
There was a problem hiding this comment.
Since postcss isn't required in this package anymore, perhaps this should be moved to a peer dependency? 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, 👋
Thanks for the package. Here are some updates to make it work with the latest postcss. This helps get rid of a GitHub vulnerability warning that has been bugging me recently. :)
It should probably be released as a major version bump.
All tests are passing:
Please let me know if you want me to change anything!