Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve clicking in diff view to enter staging/patch building #3985

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Improve clicking in diff view to enter staging/patch building #3985

wants to merge 5 commits into from

Commits on Oct 13, 2024

  1. Cleanup: get rid of the variadic parameter of ContextMgr.Push 

    Apparently this was an attempt at working around go's lack of default arguments,
but it's very unidiomatic and a bit confusing. Make it a normal parameter
instead, so all clients have to pass it explicitly.
    @stefanhaller
    stefanhaller committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    d6781f1 View commit details
    Browse the repository at this point in the history

  2. Cleanup: remove unused interfaces for helpers 

    I can only guess here: maybe they were added to more clearly document the public
interface of the classes? If so, I don't think that works. Developers who are
not familiar with the convention will just add a new public method to the class
without updating the interface.
    @stefanhaller
    stefanhaller committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    f2e1587 View commit details
    Browse the repository at this point in the history

  3. WIP

    @stefanhaller
    stefanhaller committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    b14dfb0 View commit details
    Browse the repository at this point in the history

  4. Extract some functions from CommitFilesController to a new CommitFile… 

    …sHelper
    @stefanhaller
    stefanhaller committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    29a4e99 View commit details
    Browse the repository at this point in the history

  5. WIP Click in commits view to enter patch building for clicked line 

    This involves first switching to the commit files view, and then entering the
clicked file from there.
    @stefanhaller
    stefanhaller committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    a20477d View commit details
    Browse the repository at this point in the history