Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support of http agents and proxy #61

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

louizo
Copy link

@louizo louizo commented Nov 17, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Add the possibility to provide a custom http agent on figma-js client instantiation.
This allows figma-js to be used in different environments (proxy,...)

  • What is the current behavior? (You can also link to an open issue here)

The current version of figma-js can only be used with a direct internet connection.
In specific cases such as in a company environment (example: need a proxy to connect internet), figma-js does not work.

  • What is the new behavior (if this is a feature change)?

Allowing a client to change http_agent, https_agent, or/and proxy values of axios configuration enables developers to make clients that work in more environments, such as (but not limited to) using http_proxy environment if present to connect via proxy.

  • Other information:

Figma-js interface is kept the same (new values are optional), so it is backward compatible.

@jasonmaire
Copy link

I would love to see this PR merged! Very useful for me as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants