publish: Some more refactoring

publish/src/bin/janitor-publish.rs

@@ -164,7 +164,7 @@ async fn main() -> Result<(), i32> {
     });
 
     if args.once {
-        janitor_publish::publish_pending_ready(state, args.require_binary_diff)
+        janitor_publish::publish_pending_ready(state)
             .await
             .map_err(|e| {
                 log::error!("Failed to publish pending proposals: {}", e);
@@ -186,21 +186,13 @@ async fn main() -> Result<(), i32> {
             state.clone(),
             chrono::Duration::seconds(args.interval),
             !args.no_auto_publish,
-            args.require_binary_diff,
         ));
 
         tokio::spawn(janitor_publish::refresh_bucket_mp_counts(state.clone()));
 
-        tokio::spawn(janitor_publish::listen_to_runner(
-            state.clone(),
-            args.require_binary_diff,
-        ));
+        tokio::spawn(janitor_publish::listen_to_runner(state.clone()));
 
-        let app = janitor_publish::web::app(
-            state.clone(),
-            args.require_binary_diff,
-            args.modify_mp_limit,
-        );
+        let app = janitor_publish::web::app(state.clone());
 
         // run it
         let addr = SocketAddr::new(args.listen_address, args.port);

publish/src/lib.rs

@@ -577,15 +577,11 @@ pub async fn process_queue_loop(
     state: Arc<AppState>,
     interval: chrono::Duration,
     auto_publish: bool,
-    require_binary_diff: bool,
 ) {
     todo!();
 }
 
-pub async fn publish_pending_ready(
-    state: Arc<AppState>,
-    require_binary_diff: bool,
-) -> Result<(), PublishError> {
+pub async fn publish_pending_ready(state: Arc<AppState>) -> Result<(), PublishError> {
     todo!();
 }
 
@@ -620,7 +616,7 @@ pub async fn refresh_bucket_mp_counts(state: Arc<AppState>) -> Result<(), sqlx::
     Ok(())
 }
 
-pub async fn listen_to_runner(state: Arc<AppState>, require_binary_diff: bool) {
+pub async fn listen_to_runner(state: Arc<AppState>) {
     todo!();
 }
 

publish/src/web.rs

@@ -794,11 +794,7 @@ WHERE run.id = $1
     )
 }
 
-pub fn app(
-    state: Arc<AppState>,
-    require_binary_diff: bool,
-    modify_mp_limit: Option<i32>,
-) -> Router {
+pub fn app(state: Arc<AppState>) -> Router {
     Router::new()
         .route(
             "/:campaign/merge-proposals",